Re: [PATCH v3 04/10] Move computation of dir_rename_count from merge-ort to diffcore-rename

From: Derrick Stolee <stolee@gmail.com>
Date: Feb 26, 2021, 15:55 UTC
Message-ID: <7cdfa81a-d088-f91d-c78d-6f1d957ec8b2@gmail.com>
In-Reply-To: <9b9d5b207b034ec4181020e0bf3ac46561f55b28.1614304700.git.gitgitgadget@gmail.com>

On 2/25/2021 8:58 PM, Elijah Newren via GitGitGadget wrote:

Show 5 quoted lines

> +	for (i = 0; i < rename_dst_nr; ++i) {
> +		/* File not part of directory rename counts if not a rename */
> +		if (!rename_dst[i].is_rename)
> +			continue;
> +

...

> -		/* File not part of directory rename if it wasn't renamed */
> -		if (pair->status != 'R')
> -			continue;
> -

Thanks for updating to include this check!

-Stolee

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.