Re: [cgit PATCH] use Host: header to generate cgit_hosturl

From: Lars Hjemli <hjemli@gmail.com>
Date: Sep 1, 2008, 20:36 UTC
Message-ID: <8c5c35580809011336v58b139acu5078cafd3440c786@mail.gmail.com>
In-Reply-To: <20080901063033.GA21848@untitled>

On Mon, Sep 1, 2008 at 8:30 AM, Eric Wong <normalperson@yhbt.net> wrote:

Show 12 quoted lines

> I run an instance of lighttpd for cgit behind nginx (nginx
> doesn't execute CGI).  So the port (SERVER_PORT=33333) that
> lighttpd runs on sends to cgit is different from the standard
> port 80 that public clients connect to (via nginx).
>
> This was causing the Atom feed URL to show the private port
> number that lighttpd was running on.
>
> Since the HTTP/1.1 "Host" header includes the port number if
> running on a non-standard port, it allows non-client-facing HTTP
> servers to transparently generate public URLs that clients can
> see.

This makes a lot of sense, thanks for the detailed description.

> So use the "Host" header if it is available and fall back to
> SERVER_NAME/SERVER_PORT for some clients that don't set
> HTTP_HOST.

Maybe it would be better to use a new cgitrc parameter as fallback if the client doesn't provide the "Host" header?

-- larsh