Re: [cgit PATCH] use Host: header to generate cgit_hosturl
- From
- Eric Wong <normalperson@yhbt.net>
- Date
- Sep 1, 2008, 23:07 UTC
- Message-ID
- <20080901230741.GA19984@hand.yhbt.net>
- In-Reply-To
- <8c5c35580809011336v58b139acu5078cafd3440c786@mail.gmail.com>
Lars Hjemli <hjemli@gmail.com> wrote:
Show 7 quoted lines
> On Mon, Sep 1, 2008 at 8:30 AM, Eric Wong <normalperson@yhbt.net> wrote: > > So use the "Host" header if it is available and fall back to > > SERVER_NAME/SERVER_PORT for some clients that don't set > > HTTP_HOST. > > Maybe it would be better to use a new cgitrc parameter as fallback if > the client doesn't provide the "Host" header?
That sounds a bit hackish to me since HTTP_HOST, SERVER_NAME and SERVER_PORT are all standardized. Anyhow, it's your call :)
-- Eric Wong