Re: [PATCH 3/4 v2] Add tests for .git file
- From
- Lars Hjemli <hjemli@gmail.com>
- Date
- Feb 6, 2008, 10:35 UTC
- Message-ID
- <8c5c35580802060235n52019c16j4404c06d53b47100@mail.gmail.com>
- In-Reply-To
- <7vr6fqz939.fsf@gitster.siamese.dyndns.org>
On Feb 6, 2008 11:13 AM, Junio C Hamano <gitster@pobox.com> wrote:
Show 15 quoted lines
> "Lars Hjemli" <hjemli@gmail.com> writes:
>
> > On Feb 6, 2008 9:40 AM, Junio C Hamano <gitster@pobox.com> wrote:
> >> Lars Hjemli <hjemli@gmail.com> writes:
> >> > +objpath() {
> >> > + echo $1 | sed -re 's|(..)(.+)|\1/\2|'
> >> > +}
> >>
> >> "sed -r"??? Please limit ourselves to the basics.
> >
> > Sorry, I didn't realize 'sed -r' wasn't kosher. Should I resend or is
> > this something you'd --amend?
>
> If we live in POSIX only world it is fine, but I try to be
> conservative when I am able.Ok, good to know that my lack of experience doesn't pollute the codebase ;-)
Show 6 quoted lines
> No need to resend; I've done something like this (there are
> other minor amends).
>...
> +objpath() {
> + echo "$1" | sed -e 's|\(..\)|\1/|'
> +}Thanks. -- larsh