Re: [PATCH 3/4 v2] Add tests for .git file

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 6, 2008, 10:13 UTC
Message-ID: <7vr6fqz939.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <8c5c35580802060130i12fc261aqbe9c136f26218188@mail.gmail.com>

"Lars Hjemli" <hjemli@gmail.com> writes:

Show 10 quoted lines

> On Feb 6, 2008 9:40 AM, Junio C Hamano <gitster@pobox.com> wrote:
>> Lars Hjemli <hjemli@gmail.com> writes:
>> > +objpath() {
>> > +    echo $1 | sed -re 's|(..)(.+)|\1/\2|'
>> > +}
>>
>> "sed -r"???  Please limit ourselves to the basics.
>
> Sorry, I didn't realize 'sed -r' wasn't kosher. Should I resend or is
> this something you'd --amend?

If we live in POSIX only world it is fine, but I try to be conservative when I am able.

No need to resend; I've done something like this (there are other minor amends).

    diff --git a/t/t0002-gitfile.sh b/t/t0002-gitfile.sh
    new file mode 100755
    index 0000000..d280663
    --- /dev/null
    +++ b/t/t0002-gitfile.sh
    @@ -0,0 +1,74 @@
    +#!/bin/sh
    +
    +test_description='.git file
    +
    +Verify that plumbing commands work when .git is a file
    +'
    +. ./test-lib.sh
    +
    +objpath() {
    +    echo "$1" | sed -e 's|\(..\)|\1/|'
    +}
    + ...

But the result won't be pushed out til tomorrow morning.