Re: [PATCH 5/5] Add gitmodules(5)

From: Lars Hjemli <hjemli@gmail.com>
Date: Jun 12, 2007, 08:27 UTC
Message-ID: <8c5c35580706120127p649227d8gc706cb8b364d02b9@mail.gmail.com>
In-Reply-To: <20070612080402.GQ955MdfPADPa@greensroom.kotnet.org>

On 6/12/07, Sven Verdoolaege <skimo@kotnet.org> wrote:

Show 7 quoted lines

> On Tue, Jun 12, 2007 at 09:05:21AM +0200, Lars Hjemli wrote:
> > +The file contains one subsection per submodule, and the subsection value
> > +is the name of the submodule. Each submodule section also contains the
> > +following required keys:
>
> Your only argument for making them required was that Junio thought that
> not having them might be ambiguous, but he doesn't think so anymore.

Well, I actually also had an argument about being strict in the beginning and possibly loosen the rules later on. Anyways, I can do a patch on top of this series (if/when it's accepted) and let Junio decide to apply or drop the 'optional path' stuff.

Show 7 quoted lines

>
> > +submodule.<name>.path::
> > +     Defines the path, relative to the top-level directory of the git
>
> Your previous patch had "_a_ path" instead of "_the_ path".
> I prefer the former since it allows a module to be checkoud out
> at multiple locations.

This is somewhat intentional. I want to move the submodule repos into
.git/submodules/$name/ (with working dir) and symlink this directory
when 'checking out' the submodule. This would be a simple solution for
the following problems:
  -keeping submodule modifications between checkouts
  -having submodules within submodules

Multiple checkout paths for a single submodule will bring havoc on this plan, so I need to ask: what is the use-case for multiple checkout paths?

-- 
larsh