Re: [PATCH 5/5] Add gitmodules(5)

From: Sven Verdoolaege <skimo@kotnet.org>
Date: Jun 12, 2007, 08:04 UTC
Message-ID: <20070612080402.GQ955MdfPADPa@greensroom.kotnet.org>
In-Reply-To: <11816319211097-git-send-email-hjemli@gmail.com>

On Tue, Jun 12, 2007 at 09:05:21AM +0200, Lars Hjemli wrote:

> +The file contains one subsection per submodule, and the subsection value
> +is the name of the submodule. Each submodule section also contains the
> +following required keys:

Your only argument for making them required was that Junio thought that not having them might be ambiguous, but he doesn't think so anymore.

> +submodule.<name>.path::
> +	Defines the path, relative to the top-level directory of the git

Your previous patch had "_a_ path" instead of "_the_ path". I prefer the former since it allows a module to be checkoud out at multiple locations.

skimo