Re: [PATCH 2/3] Add gitmodules(5)

From: Lars Hjemli <hjemli@gmail.com>
Date: Jun 10, 2007, 12:51 UTC
Message-ID: <8c5c35580706100551y52639ce3m7a2be93a3289be1c@mail.gmail.com>
In-Reply-To: <20070610124052.GE955MdfPADPa@greensroom.kotnet.org>

On 6/10/07, Sven Verdoolaege <skimo@kotnet.org> wrote:

Show 14 quoted lines

> On Sun, Jun 10, 2007 at 02:30:58PM +0200, Lars Hjemli wrote:
> > On 6/10/07, Sven Verdoolaege <skimo@kotnet.org> wrote:
> > >On Sun, Jun 10, 2007 at 10:58:29AM +0200, Lars Hjemli wrote:
> > >> >For .path a "Defaults to name of submodule" probably wouldn't hurt.
> > >>
> > >> True. But there might be some issues with this rule, so I'll leave it
> > >> as is for now.
> > >
> > >And what might those issues be?
> >
> > There's been some discussion about allowing a default value for path, see
> >  http://comments.gmane.org/gmane.comp.version-control.git/49620
>
> Euhm... this just points back to this thread...

I know ;-)

> or are you referring to Junio's misinterpretation of the patch 1/3
> commit message?

Well, yes, I _think_ it's a misinterpretation but there is always the possibility of me being exceptionally slow and not getting his point.

Show 12 quoted lines

>
> > >It doesn't have the extensions proposed by Linus, but it seems
> > >to be forward compatible with them.
> >
> > I'm trying to take baby-steps with the submodule support, so the
> > module/submodule extension Linus talked about would possibly come at a
> > later stage.
> >
> > Hmm, maybe I should just rename [module] to [submodule] right now?
>
> I don't see the need, but if you _really_ can't resist then please do it
> sooner rather than later.

Ok

-- larsh