Re: [PATCH 2/3] Add gitmodules(5)
- From
- Lars Hjemli <hjemli@gmail.com>
- Date
- Jun 10, 2007, 12:30 UTC
- Message-ID
- <8c5c35580706100530g256de4a4yb12f4647dae06500@mail.gmail.com>
- In-Reply-To
- <20070610121202.GD955MdfPADPa@greensroom.kotnet.org>
On 6/10/07, Sven Verdoolaege <skimo@kotnet.org> wrote:
Show 17 quoted lines
> On Sun, Jun 10, 2007 at 10:58:29AM +0200, Lars Hjemli wrote: > > On 6/10/07, Frank Lichtenheld <frank@lichtenheld.de> wrote: > > >> +Each submodule can contain the following keys. > > >> + > > >> +module.$name.path:: > > >> + Define a path, relative to the top-level directory of the git > > >> + working tree, where the submodule is expected to be checked out. > > >> + > > >> +module.$name.url:: > > >> + Define a url from where the submodule repository can be cloned. > > > > > >For .path a "Defaults to name of submodule" probably wouldn't hurt. > > > > True. But there might be some issues with this rule, so I'll leave it > > as is for now. > > And what might those issues be?
There's been some discussion about allowing a default value for path, see http://comments.gmane.org/gmane.comp.version-control.git/49620
Show 12 quoted lines
> > How about adding something like > > For a given path relative to the top-level directory of the > git working tree, the logical name of the submodule at that > path (if any) is the submodule <name> with a module.<name>.path > value equal to that path, or, if no such submodule exists, the > submodule <path>. It is an error for different submodules to have > identical path values. > > For uniformity, you may also want to specify that a path value > must (or must not) end with a slash.
Nice suggestions, I'll try to come up with a new patch later today
> Other than that, I like it.
Thanks :)
> It doesn't have the extensions proposed by Linus, but it seems > to be forward compatible with them.
I'm trying to take baby-steps with the submodule support, so the module/submodule extension Linus talked about would possibly come at a later stage.
Hmm, maybe I should just rename [module] to [submodule] right now? It would be better forward compatible with the proposed extension, it would 'harmonize' the section names used in .gitmodules and .git/config, and it would offer a clean break from what's currently supported in 'master'.
-- larsh