Re: [PATCH] Add git-submodule command

From: Lars Hjemli <hjemli@gmail.com>
Date: May 25, 2007, 22:33 UTC
Message-ID: <8c5c35580705251533r21a3dea5w5d263fad9f8bbfa7@mail.gmail.com>
In-Reply-To: <Pine.LNX.4.64.0705251924280.4648@racer.site>

On 5/25/07, Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:

> [* many usefull comments about the docs *]

Thanks, will fix

Show 9 quoted lines

> > +USAGE='[--init | --update | --cached] [--quiet] [--] [<path>...]'
> > +. git-sh-setup
> > +require_work_tree
>
> Maybe
>
>         test -f "$GIT_DIR"/.gitmodules || die "Not a superproject"
>
> Hmm?

Yeah, maybe. But the command will only touch entries with mode 160000 anyway, so it might not be a big deal.

>
> > +                     rmdir "$path" 2>/dev/null ||
>
> Just out of curiousity: is rmdir portable? I always used "rm -r"...

I have no idea, really. But the reason for using rmdir was this section of the man page:

NAME
       rmdir - remove empty directories

I do not want to delete an unempty directory. But there is probably some better way to do this?

-- larsh