git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH/RFC 0/3] Split fetch and merge logic

From
SBSanti Béjar <sbejar@gmail.com>
Date
Feb 16, 2007, 20:30 UTC
Message-ID
<8aa486160702161230r6f5825a2v861315c1aa52520e@mail.gmail.com>
In-Reply-To
<7vd54950ed.fsf@assigned-by-dhcp.cox.net>
On 2/16/07, Junio C Hamano <junkio@cox.net> wrote:
Show 18 quoted lines
> "Santi Béjar" <sbejar@gmail.com> writes:
>
> > In the past we've had problems when we have changed the merge logic
> > (as shows 4363dfbe3). This patch makes the two process completely
> > independent, and concentrate the merge logic in one place (leaving
> > git-parse-remote.sh independent of the merge logic).
>
> But that is a solved problem, isn't it?  What else does it
> solve?  The justification for moving around the logic could be
> something like "these three patches do not do that themselves,
> but it opens a door for further work such as ...", but without
> something concrete in "..." part, your response makes the patch
> look mostly needless code churn.
>
> I was hoping to hear something like "now git-fetch has to do
> much less than before, eventual C-rewrite of the command, which
> can borrow some code already written for 'pu' branch, will
> become much easier" ;-).
This sounds like a good justification, also :-)
Santi
Previous: Junio C HamanoNext: Junio C Hamano
Message 11 of 14 in “Split fetch and merge logic”
  1. 0/3 Split fetch and merge logicSanti Béjar, Feb 16, 2007
  2. 2/3 git-fetch: Split fetch and merge logicSanti Béjar, Feb 16, 2007
  3. Junio C HamanoFeb 19, 2007
  4. Santi BéjarFeb 19, 2007
  5. Junio C HamanoFeb 19, 2007
  6. Santi BéjarFeb 20, 2007
  7. 3/3 t/t5515: fixes for the separate fetch and merge logicSanti Béjar, Feb 16, 2007
  8. Junio C HamanoFeb 16, 2007
  9. Santi BéjarFeb 16, 2007
  10. Junio C HamanoFeb 16, 2007
  11. Santi BéjarFeb 16, 2007
  12. Junio C HamanoFeb 16, 2007
  13. Santi BéjarFeb 19, 2007
  14. Santi BéjarFeb 16, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.