Re: [PATCH/RFC 0/3] Split fetch and merge logic

From: Junio C Hamano <junkio@cox.net>
Date: Feb 16, 2007, 20:10 UTC
Message-ID: <7vd54950ed.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <8aa486160702160040t3f42b5a0xbd12f333805ad4d7@mail.gmail.com>

"Santi Béjar" <sbejar@gmail.com> writes:

> In the past we've had problems when we have changed the merge logic
> (as shows 4363dfbe3). This patch makes the two process completely
> independent, and concentrate the merge logic in one place (leaving
> git-parse-remote.sh independent of the merge logic).

But that is a solved problem, isn't it? What else does it solve? The justification for moving around the logic could be something like "these three patches do not do that themselves, but it opens a door for further work such as ...", but without something concrete in "..." part, your response makes the patch look mostly needless code churn.

I was hoping to hear something like "now git-fetch has to do much less than before, eventual C-rewrite of the command, which can borrow some code already written for 'pu' branch, will become much easier" ;-).