Re: feature request, git-gui: add hotkey to toggle amend/new
- From
Johannes Sixt <j6t@kdbg.org>
- Date
- Sep 4, 2019, 18:52 UTC
- Message-ID
- <8a726eea-f461-db90-7e36-70b708ff8915@kdbg.org>
- In-Reply-To
- <20190904174103.nrntgwv6zdqyjqsh@yadavpratyush.com>
Am 04.09.19 um 19:46 schrieb Pratyush Yadav:
Show 9 quoted lines
> On 04/09/19 08:24AM, Johannes Sixt wrote: >> That is worth a try. The check box title offers a natural hotkey then: >> "_A_mend last commit", Alt-a. > > Right now, the binding proposed is Ctrl-e. My mental model for the key > bindings as of now is having the "actions" bound to Ctrl, and bindings > that move you around in the UI bound to Alt. So it makes more sense to > me to have a "amend toggle" bound to Ctrl. Maybe that's just me though. > Anyone else care to chime in?
"Amend last commit" is NOT an action. It switches a state.
It is common in Windows GUIs that every control, including menu items, has a hotkey associated, the underlined letter in the caption, and the hotkey to access that UI control is Alt+that letter. It's not necessarily a matter of moving around.
And, BTW, this hotkey thing is also the case on my Linux desktop (KDE-based).
But of course, git-gui is different and totally off track here. It has *zero* controls marked for hotkey-accessibility. I was just hoping to spark an effort to make some of the controls marked and hotkey-accessible.
-- Hannes