Re: feature request, git-gui: add hotkey to toggle amend/new

From: Pratyush Yadav <me@yadavpratyush.com>
Date: Sep 11, 2019, 18:34 UTC
Message-ID: <20190911183419.jea27ctvcdl5olp3@yadavpratyush.com>
In-Reply-To: <CAGr--=Jdj+kJmV7z3vhYW+s129+0+KgbNYw8NFPmSASRYMTdbg@mail.gmail.com>

On 11/09/19 12:27PM, Birger Skogeng Pedersen wrote:

Show 6 quoted lines

> Hi Pratyush,
> 
> I'm hoping this will be merged, even without changing the radio
> selectors to a checkbox(?). The patch from Bert resolves the issue I
> raised about wanting the hotkey.
> What do you think?

What do you mean by "this"? I am guessing you mean [0].

I'm afraid that patch conflicts with Bert's change [1] to using a checkbox. Since both patches are in flight, it makes more sense to base your work off his. If I merge your patch now, I'll have to revert it as soon as it is time to merge Bert's, and then rework your patch.

Also, after Bert's patch, the toggling becomes much simpler. All you'd have to do is something like:

  bind . <$M1B-Key-e> {
	# Toggle commit type.
	set commit_type_is_amend [expr {!$commit_type_is_amend}]
	do_select_commit_type
  }

Maybe a cleaner way is possible, but this is what I could come up with for toggling a boolean.

So can you please send a re-roll based on Bert's patch? I took a quick glance at it, and it seems mostly correct. I have a couple of comments, so some things might change based on the discussion, but I don't think it should affect your change too much.

[0] https://public-inbox.org/git/20190904175943.11924-1-birger.sp@gmail.com/ [1] https://public-inbox.org/git/ab1f68cc8552e405c9d04622be1e728ab81bda17.1567713659.git.bert.wesarg@googlemail.com/

-- 
Regards,
Pratyush Yadav