git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] gitk: Add a "Save file as" menu item

From
AAAndreas Amann <a.amann@ucc.ie>
Date
Jul 21, 2013, 19:53 UTC
Message-ID
<87zjtfhepo.fsf@msstf091.ucc.ie>
In-Reply-To
<alpine.DEB.2.00.1307211910250.9615@ds9.cixit.se>
Peter Krefting <peter@softwolves.pp.se> writes:
Show 12 quoted lines
> Andreas Amann:
>
>> +    set difffile "$diffidtext [file tail $flist_menu_file]"
>> +    set difffile [tk_getSaveFile -initialfile $difffile -title "Save file as" -parent .]
>> +    if {$difffile eq {}} {
>> +	return
>> +    }
>> +    save_file_from_commit $diffid:$flist_menu_file $difffile "revision $diffid"
>
> I might be misunderstanding the code (this is not one of my preferred 
> programming languages), but it looks like this is missing the gettext 
> markers necessary to get these strings localized.
thanks for pointing this out.  Will resend an updated patch.
Previous: Peter KreftingNext: Andreas Amann
Message 3 of 5 in “gitk: Add a "Save file as" menu item”
  1. gitk: Add a "Save file as" menu itemAndreas Amann, Jul 21, 2013
  2. Peter KreftingJul 21, 2013
  3. Andreas AmannJul 21, 2013
  4. gitk: Add a "Save file as" menu itemAndreas Amann, Jul 21, 2013
  5. gitk: Add a "Save file as" menu itemAndreas Amann, Jul 28, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.