From: Andreas Amann <a.amann@ucc.ie>
Date: Sun, 21 Jul 2013 19:53:39 GMT
Subject: Re: [PATCH] gitk: Add a "Save file as" menu item
Message-ID: <87zjtfhepo.fsf@msstf091.ucc.ie>
In-Reply-To: <alpine.DEB.2.00.1307211910250.9615@ds9.cixit.se>

Peter Krefting <peter@softwolves.pp.se> writes:
> Andreas Amann:
>
>> +    set difffile "$diffidtext [file tail $flist_menu_file]"
>> +    set difffile [tk_getSaveFile -initialfile $difffile -title "Save file as" -parent .]
>> +    if {$difffile eq {}} {
>> +	return
>> +    }
>> +    save_file_from_commit $diffid:$flist_menu_file $difffile "revision $diffid"
>
> I might be misunderstanding the code (this is not one of my preferred 
> programming languages), but it looks like this is missing the gettext 
> markers necessary to get these strings localized.

thanks for pointing this out.  Will resend an updated patch.