git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [GSoC][PATCH] commit: add a commit.signOff config variable

From
Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date
Feb 4, 2018, 18:59 UTC
Message-ID
<87zi4olgwh.fsf@evledraar.gmail.com>
In-Reply-To
<20180204113135.GA28130@flurp.local>
On Sun, Feb 04 2018, Eric Sunshine jotted:
Show 34 quoted lines
> --- >8 ---
> for cfg in true false
> do
>     for opt in '' --signoff --no-signoff
>     do
>         case "$opt:$cfg" in
>         --signoff:*|:true) expect= ;;
>         --no-signoff:*|:false) expect=! ;;
>         esac
>         test_expect_success "commit.signoff=$cfg & ${opt:---signoff omitted}" '
>             git -c commit.signoff=$cfg commit --allow-empty -m x $opt &&
>             eval "$expect git log -1 --format=%B | grep ^Signed-off-by:"
>         '
>     done
> done
> --- >8 ---
>
> A final consideration is that tests run slowly on Windows, and although
> it's nice to be thorough by testing all six combinations, you can
> probably exercise the new code sufficiently by instead testing just two
> combinations. For instance, instead of all six combinations, test just
> these two:
>
> --- >8 ---
> test_expect_success 'commit.signoff=true & --signoff omitted' '
>     git -c commit.signoff=true commit --allow-empty -m x &&
>     git log -1 --format=%B | grep ^Signed-off-by:
> '
>
> test_expect_success 'commit.signoff=true & --no-signoff' '
>     git -c commit.signoff=true commit --allow-empty -m x --no-signoff &&
>     ! git log -1 --format=%B | grep ^Signed-off-by:
> '
> --- >8 ---

I just skimmed this, but just to this question. I don't think we need to worry about 2 v.s. 6 tests having an impact on Windows performance, it's just massive amounts of tests like my in-flight wildmatch test series that really matter.

But if we are worring about 2 v.s. 6 there's always my in-flight EXPENSIVE_ON_WINDOWS prereq :)

Previous: Eric SunshineNext: Stefan Beller
Message 3 of 5 in “commit: add a commit.signOff config variable”
  1. Chen JingpiaoFeb 4, 2018
  2. Eric SunshineFeb 4, 2018
  3. Ævar Arnfjörð BjarmasonFeb 4, 2018
  4. Stefan BellerFeb 5, 2018
  5. Chen JingpiaoFeb 6, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.