Re: [GSoC][PATCH] commit: add a commit.signOff config variable

From: Chen Jingpiao <chenjingpiao@gmail.com>
Date: Feb 6, 2018, 07:01 UTC
Message-ID: <20180206070151.GA16810@ppiao>
In-Reply-To: <CAGZ79kZgqDp49McgtzWRbArsK6qVz1E9Syi5tJo73F-+T4UOiA@mail.gmail.com>

On 02/05 01:50, Stefan Beller wrote:

Show 21 quoted lines

> On Sat, Feb 3, 2018 at 6:03 PM, Chen Jingpiao <chenjingpiao@gmail.com> wrote:
> > Add the commit.signOff configuration variable to use the -s or --signoff
> > option of git commit by default.
> >
> > Signed-off-by: Chen Jingpiao <chenjingpiao@gmail.com>
> > ---
> 
> Welcome to the Git community!
> 
> >
> > Though we can configure signoff using format.signOff variable. Someone like to
> > add Signed-off-by line by the committer.
> 
> There is more discussion about this at
> https://public-inbox.org/git/1482946838-28779-1-git-send-email-ehabkost@redhat.com/
> specifically
> https://public-inbox.org/git/xmqqtw9m5s5m.fsf@gitster.mtv.corp.google.com/
> 
> Not sure if there was any other reasons and discussions brought up
> since then, but that discussion seems to not favor patches that
> add .signoff options.

Thank you.

I agree with Johannes Schindelin once said "a signoff _has_ to be a conscious act, or else it will lose its meaning." I think I shouldn't add this configuration variable.

When add configuration variable for sign-off to format-patch have some discussion:
	https://public-inbox.org/git/20090331204338.GA88381@macbook.lan/
	https://public-inbox.org/git/20090401102610.GC26181@coredump.intra.peff.net/
	https://public-inbox.org/git/7veiw69p26.fsf@gitster.siamese.dyndns.org/

-- Chen Jingpiao