git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: ab/fsck-unexpected-type (and "cat-file replace handling and optimization")

From
Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date
Oct 6, 2021, 08:54 UTC
Message-ID
<87y276ilc8.fsf@evledraar.gmail.com>
In-Reply-To
<YVzLRSa9/vUWJPL0@coredump.intra.peff.net>
On Tue, Oct 05 2021, Jeff King wrote:
Show 28 quoted lines
> On Tue, Oct 05, 2021 at 10:47:26PM +0200, Ævar Arnfjörð Bjarmason wrote:
>
>> > * ab/fsck-unexpected-type (2021-10-01) 17 commits
>> [...]
>> Note that Jeff's just-submitted cat-file series[3] will conflict with
>> this, as they both adjust the same "garbage" object tests. The semantic
>> conflict is minimal/none, but the textual one is probably annoying
>> (e.g. his 1/5 uses a variable I split/renamed).
>> 
>> Jeff: Depending on what Junio thinks of queuing ab/fsck-unexpected-type
>> for next what do you think about rebasing your series on top, or perhaps
>> take a look at the v10[4] of it/ack it in case that helps with that (since
>> you've been looking at some related code just now...).
>
> The conflict is pretty easy to resolve: just keep my new cleanup tests,
> but swap out the variable name. The combined diff is below for
> reference (this is more readable than a remerge diff, but I guess a
> remerge diff could actually be applied).
>
> I don't mind rebasing on top if that's easier for Junio, but in that
> case it may make sense to float the test cleanup to the front of the
> series.
>
> I can also just change mine to do the --batch-all-objects tests in a
> separate repository (which is what the existing ones do). That has the
> minor advantage that we know all objects in the repository, so rather
> than picking out the interesting object with perl, we could generate the
> full expected output.

Thanks, your plan sounds better. I hadn't tried the merge when I sent that E-Mail, just saw your series & that it would conflict, wanted to give you/Junio a headsup.

Previous: Jeff KingNext: Junio C Hamano
Message 8 of 15 in “What's cooking in git.git (Oct 2021, #01; Mon, 4)”
  1. Junio C HamanoOct 4, 2021
  2. Taylor BlauOct 4, 2021
  3. ab/refs-errno-cleanupÆvar Arnfjörð Bjarmason, Oct 5, 2021
  4. hm/paint-hits-in-log-grepÆvar Arnfjörð Bjarmason, Oct 5, 2021
  5. ab/designated-initializers-moreÆvar Arnfjörð Bjarmason, Oct 5, 2021
  6. ab/fsck-unexpected-type (and "cat-file replace handling and optimization")Ævar Arnfjörð Bjarmason, Oct 5, 2021
  7. Jeff KingOct 5, 2021
  8. Ævar Arnfjörð BjarmasonOct 6, 2021
  9. Junio C HamanoOct 7, 2021
  10. Jeff KingOct 8, 2021
  11. Junio C HamanoOct 8, 2021
  12. ab/make-sparse-for-realÆvar Arnfjörð Bjarmason, Oct 6, 2021
  13. ab/parse-options-cleanup & ab/align-parse-options-help & ab/help-config-varsÆvar Arnfjörð Bjarmason, Oct 6, 2021
  14. Junio C HamanoOct 6, 2021
  15. ab/refs-errno-cleanup & "errno" removal in the refs backendÆvar Arnfjörð Bjarmason, Oct 6, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.