git/list[1] front-page[2] threads[3] people[4] search[5] about
 

hm/paint-hits-in-log-grep

From
Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date
Oct 5, 2021, 16:47 UTC
Message-ID
<87r1czjtzu.fsf@evledraar.gmail.com>
In-Reply-To
<xmqqo884tkxd.fsf@gitster.g>
On Mon, Oct 04 2021, Junio C Hamano wrote:
Show 10 quoted lines
> * hm/paint-hits-in-log-grep (2021-09-29) 3 commits
>  - pretty: colorize pattern matches in commit messages
>  - grep: refactor next_match() and match_one_pattern() for external use
>  - Merge branch 'jk/grep-haystack-is-read-only' into hm/paint-hits-in-log-grep
>  (this branch uses jk/grep-haystack-is-read-only.)
>
>  "git log --grep=string --author=name" learns to highlight hits just
>  like "git grep string" does.
>
>  Will merge to 'next'?
Encodings, timezones and ... taxes? Anyway.

I tested this and it LGTM, but I found a bug in how it handles UTF-8 & interacts with i18n.{log,commit}Encoding. See https://lore.kernel.org/git/87v92bju64.fsf@evledraar.gmail.com/

I've got a WIP patch there on top (which I forgot to include a Signed-off-by, but Hamza: You can assume it's there:). It *should* be fairly easy to fix in a final v11, but maybe I've only gleamed the entry of that particular rabbit hole so far ... :)

Previous: Ævar Arnfjörð BjarmasonNext: Ævar Arnfjörð Bjarmason
Message 4 of 15 in “What's cooking in git.git (Oct 2021, #01; Mon, 4)”
  1. Junio C HamanoOct 4, 2021
  2. Taylor BlauOct 4, 2021
  3. ab/refs-errno-cleanupÆvar Arnfjörð Bjarmason, Oct 5, 2021
  4. hm/paint-hits-in-log-grepÆvar Arnfjörð Bjarmason, Oct 5, 2021
  5. ab/designated-initializers-moreÆvar Arnfjörð Bjarmason, Oct 5, 2021
  6. ab/fsck-unexpected-type (and "cat-file replace handling and optimization")Ævar Arnfjörð Bjarmason, Oct 5, 2021
  7. Jeff KingOct 5, 2021
  8. Ævar Arnfjörð BjarmasonOct 6, 2021
  9. Junio C HamanoOct 7, 2021
  10. Jeff KingOct 8, 2021
  11. Junio C HamanoOct 8, 2021
  12. ab/make-sparse-for-realÆvar Arnfjörð Bjarmason, Oct 6, 2021
  13. ab/parse-options-cleanup & ab/align-parse-options-help & ab/help-config-varsÆvar Arnfjörð Bjarmason, Oct 6, 2021
  14. Junio C HamanoOct 6, 2021
  15. ab/refs-errno-cleanup & "errno" removal in the refs backendÆvar Arnfjörð Bjarmason, Oct 6, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.