Re: [PATCH v2] commit-slab: declare functions "static inline"

From: Thomas Rast <tr@thomasrast.ch>
Date: Nov 25, 2013, 20:15 UTC
Message-ID: <87wqjw1bm5.fsf@thomasrast.ch>
In-Reply-To: <20131125201200.GN4212@google.com>

Jonathan Nieder <jrnieder@gmail.com> writes:

Show 16 quoted lines

> Thomas Rast wrote:
>
>> This shuts up compiler warnings about unused functions.
>
> If that is the only goal, I think it would be cleaner to use
>
> 	#define MAYBE_UNUSED __attribute__((__unused__))
>
> 	static MAYBE_UNUSED void init_ ...
>
> like was done in the vcs-svn/ directory until cba3546 (drop obj_pool,
> 2010-12-13) et al.
>
> I haven't thought carefully about whether encouraging inlining here
> (or encouraging the reader to think of these functions as inline) is a
> good or bad change.

Hmm.

I actually had this idea after seeing the same trick in khash.h. Is __atribute__((__unused__)) universal? If so, maybe we could apply the same also to khash? If not, I'd rather go with the inline.

-- 
Thomas Rast
tr@thomasrast.ch