Re: [PATCH 12/13] refs.c: use a bit for ref_update have_old
Stefan Beller <sbeller@google.com> writes:
Show 10 quoted lines
> diff --git a/refs.c b/refs.c
> index b54b5b3..2942227 100644
> --- a/refs.c
> +++ b/refs.c
> @@ -3532,7 +3532,7 @@ struct ref_update {
> unsigned char new_sha1[20];
> unsigned char old_sha1[20];
> int flags; /* REF_NODEREF? */
> - int have_old; /* 1 if old_sha1 is valid, 0 otherwise */
> + int have_old:1; /* 1 if old_sha1 is valid, 0 otherwise */A signed one-bit field cannot store a value of 1.
Andreas.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
Andreas Schwab <schwab@linux-m68k.org>