Re: Write and Submit Your First Kernel Patch

From: Michal Nazarewicz <mina86@tlen.pl>
Date: Oct 23, 2009, 19:41 UTC
Message-ID: <87vdi5uccy.fsf@erwin.mina86.com>
In-Reply-To: <dc1d0f40910231219l600d3579i57c7580fe798d445@mail.gmail.com>

Show 10 quoted lines

>> Kevyn-Alexandre Paré <kevyn.alexandre.pare@gmail.com> writes:
>>> 0001-Staging-comedi-driver-fix-coding-style.patch:27: ERROR: trailing whitespace
>>> 0001-Staging-comedi-driver-fix-coding-style.patch:35: ERROR: trailing whitespace
>>> 0001-Staging-comedi-driver-fix-coding-style.patch:43: ERROR: trailing whitespace
>>> 0001-Staging-comedi-driver-fix-coding-style.patch:53: ERROR: trailing whitespace
>>>
>>> I have done a step by step explanation of what I have done:
>>> http://kapare.blogspot.com/2009/09/write-and-submit-your-first-kernel.html>>
>>> It seem to me that the whitespace are added after I do this command:
>>> git format-patch -s -n master..mybranch

> On Fri, Oct 23, 2009 at 3:13 PM, Michal Nazarewicz <mina86@tlen.pl> wrote:
>> Do "git rebase --whitespace=fix master" and git will try to fix whitespaces.

Kevyn-Alexandre Paré <kevyn.alexandre.pare@gmail.com> writes:

> thx Michal,
>
> But the problem remain:

If I'm not mistaken "git rebase --whitespace=fix master" should do the trick. I'm out of good ideas if it does not. Best I can advice is to fix the patch by hand -- just edit it in some decent editor and remove trailing whitespaces from those lines.

-- 
Best regards,                                         _     _
 .o. | Liege of Serenly Enlightened Majesty of      o' \,=./ `o
 ..o | Computer Science,  Michal "mina86" Nazarewicz   (o o)
 ooo +--<mina86*tlen.pl>--<jid:mina86*jabber.org>--ooO--(_)--Ooo--