git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: Write and Submit Your First Kernel Patch

From
Junio C Hamano <gitster@pobox.com>
Date
Oct 23, 2009, 19:52 UTC
Message-ID
<7v8wf1c2h9.fsf@alter.siamese.dyndns.org>
In-Reply-To
<dc1d0f40910231146y14028f4el9753debdf334103@mail.gmail.com>
Kevyn-Alexandre Paré  <kevyn.alexandre.pare@gmail.com> writes:
Show 14 quoted lines
> Just before I send my patch I got this error with:
> ./scripts/checkpatch.pl --terse --file
> 0001-Staging-comedi-driver-fix-coding-style.patch
>
> 0001-Staging-comedi-driver-fix-coding-style.patch:27: ERROR: trailing whitespace
> 0001-Staging-comedi-driver-fix-coding-style.patch:35: ERROR: trailing whitespace
> 0001-Staging-comedi-driver-fix-coding-style.patch:43: ERROR: trailing whitespace
> 0001-Staging-comedi-driver-fix-coding-style.patch:53: ERROR: trailing whitespace
>
> I have done a step by step explanation of what I have done:
> http://kapare.blogspot.com/2009/09/write-and-submit-your-first-kernel.html
>
> It seem to me that the whitespace are added after I do this command:
> git format-patch -s -n master..mybranch

"The whitespace are added after..." sounds to me that what you committed were checkpatch compliant, and format-patch somehow broke it. If that is the case we need to fix format-patch.

Please check if "git show $commit" output for the commit that corresponds to the "[Staging] comedi driver: fix coding style" patch has trailing whitespaces. That is what you committed.

If there already is whitespace breakage in what you committed, then we do not have to blame format-patch and look for bugs in it to fix.

Otherwise, please send 0001-*.patch (output from format-patch) and output from that "git show $commit" as separate attachments, so that we can debug and fix format-patch.

Thanks.
Previous: Kevyn-Alexandre ParéNext: Kevyn-Alexandre Paré
Message 2 of 8 in “Write and Submit Your First Kernel Patch”
  1. Kevyn-Alexandre ParéOct 23, 2009
  2. Junio C HamanoOct 23, 2009
  3. Kevyn-Alexandre ParéOct 23, 2009
  4. Kevyn-Alexandre ParéOct 23, 2009
  5. Daniel BarkalowOct 23, 2009
  6. Junio C HamanoOct 23, 2009
  7. Kevyn-Alexandre ParéOct 23, 2009
  8. Michal NazarewiczOct 23, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.