Re: What's cooking in git.git (Nov 2013, #05; Thu, 21)

From: Thomas Rast <tr@thomasrast.ch>
Date: Nov 22, 2013, 17:58 UTC
Message-ID: <87vbzkiahs.fsf@linux-k42r.v.cablecom.net>
In-Reply-To: <20131122172626.GA4881@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

>> Hmm, maybe I missed something, but AFAICS you (or Vicent) never acted on
>> or responded to my June reviews in this thread:
>> 
>>   http://thread.gmane.org/gmane.comp.version-control.git/228918

[...]

Show 7 quoted lines

>> Granted, the way I verified this was checking whether you renamed
>> rlw_xor_run_bit() to something more fitting, so perhaps you just forgot
>> that one thing but did all the rest.
>
> I didn't touch that. Vicent, did you have a comment on the name (it
> really does look like it is a negation, and the only caller is
> ewah_not).

Hmm, so it really was that one unlucky thing :-)

I don't have much to say on the area, but if you think it helps you I can set aside some time RSN to review the second half of the series, too. Back in June I only looked at the first half.

-- 
Thomas Rast
tr@thomasrast.ch