Re: What's cooking in git.git (Nov 2013, #05; Thu, 21)

From: Jeff King <peff@peff.net>
Date: Nov 22, 2013, 22:36 UTC
Message-ID: <20131122223654.GB7538@sigill.intra.peff.net>
In-Reply-To: <87vbzkiahs.fsf@linux-k42r.v.cablecom.net>

On Fri, Nov 22, 2013 at 06:58:55PM +0100, Thomas Rast wrote:

Show 5 quoted lines

> > I didn't touch that. Vicent, did you have a comment on the name (it
> > really does look like it is a negation, and the only caller is
> > ewah_not).
> 
> Hmm, so it really was that one unlucky thing :-)

I don't promise there is only one unlucky thing. :) Only that we made a good faith effort to address the comments. There were a lot of comments and a lot of re-rolls, and I would not be surprised if something else was missed (I am not thinking of anything in particular, but just preparing you mentally).

> I don't have much to say on the area, but if you think it helps you I
> can set aside some time RSN to review the second half of the series,
> too.  Back in June I only looked at the first half.

I would love that. My comments to Junio were not to rush the topic, but mainly to keep it progressing.

Re-rolling such a big chunk of code _is_ a pain for both me and for reviewers, so I wouldn't mind switching to "fixes on top" instead of re-rolling at some point. But we can do another round or two of re-roll first.

-Peff