Re: [PATCH v2 6/7] reflog-walk: stop using fake parents

From: Kyle Meyer <kyle@kyleam.com>
Date: Jul 7, 2017, 15:54 UTC
Message-ID: <87van48cpu.fsf@kyleam.com>
In-Reply-To: <20170707091407.nm4pm3bdvx6alohs@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 9 quoted lines

>      Prior to this commit, we show both entries with
>      identical reflog messages. After this commit, we show
>      only the "comes back" entry. See the update in t3200
>      which demonstrates this.
>
>      Arguably either is fine, as the whole double-entry
>      thing is a bit hacky in the first place. And until a
>      recent fix, we truncated the traversal in such a case
>      anyway, which was _definitely_ wrong.

Yeah, I agree that the double-entry thing is a bit hacky and only showing the "comes back" entry makes sense.

And with this change, I believe that the display of a rename event will be the same for HEAD's log and the renamed branch's log, despite the underlying entries having a different representation.

-- 
Kyle