git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v4 0/9] Make submodules work if .gitmodules is not checked out

From
Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date
Aug 24, 2018, 14:38 UTC
Message-ID
<87va7zesn2.fsf@evledraar.gmail.com>
In-Reply-To
<20180824132951.8000-1-ao2@ao2.it>
On Fri, Aug 24 2018, Antonio Ospite wrote:
> this series teaches git to try and read the .gitmodules file from the
> index (:.gitmodules) and the current branch (HEAD:.gitmodules) when it
> is not readily available in the working tree.

FWIW I didn't read any of the earlier series's, and I'm not that familiar with the submodule code, but having skimmed this all (not live tested at all) nothing jumped out at me as an issue, I just had some minor style / potential memory leak nits on 1/9.

Previous: Antonio Ospite
Message 14 of 14 in “Make submodules work if .gitmodules is not checked out”
  1. 0/9 Make submodules work if .gitmodules is not checked outAntonio Ospite, Aug 24, 2018
  2. 4/9 t7411: be nicer to future tests and really clean things upAntonio Ospite, Aug 24, 2018
  3. 1/9 submodule: add a print_config_from_gitmodules() helperAntonio Ospite, Aug 24, 2018
  4. Ævar Arnfjörð BjarmasonAug 24, 2018
  5. Antonio OspiteAug 24, 2018
  6. Antonio OspiteSep 4, 2018
  7. 9/9 submodule: support reading .gitmodules when it's not in the working treeAntonio Ospite, Aug 24, 2018
  8. 2/9 submodule: factor out a config_set_in_gitmodules_file_gently functionAntonio Ospite, Aug 24, 2018
  9. 3/9 t7411: merge tests 5 and 6Antonio Ospite, Aug 24, 2018
  10. 6/9 submodule: use the 'submodule--helper config' commandAntonio Ospite, Aug 24, 2018
  11. 8/9 submodule: add a helper to check if it is safe to write to .gitmodulesAntonio Ospite, Aug 24, 2018
  12. 7/9 t7506: clean up .gitmodules properly before setting up new scenarioAntonio Ospite, Aug 24, 2018
  13. 5/9 submodule--helper: add a new 'config' subcommandAntonio Ospite, Aug 24, 2018
  14. Ævar Arnfjörð BjarmasonAug 24, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.