git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v4 3/9] t7411: merge tests 5 and 6

From
Antonio Ospite <ao2@ao2.it>
Date
Aug 24, 2018, 13:29 UTC
Message-ID
<20180824132951.8000-4-ao2@ao2.it>
In-Reply-To
<20180824132951.8000-1-ao2@ao2.it>

Tests 5 and 6 check for the effects of the same commit, merge the two tests to make it more straightforward to clean things up after the test has finished.

The cleanup will be added in a future commit.
Signed-off-by: Antonio Ospite <ao2@ao2.it>
---
 t/t7411-submodule-config.sh | 18 +++++-------------
 1 file changed, 5 insertions(+), 13 deletions(-)
diff --git a/t/t7411-submodule-config.sh b/t/t7411-submodule-config.sh
index 0bde5850ac..f2cd1f4a2c 100755
--- a/t/t7411-submodule-config.sh
+++ b/t/t7411-submodule-config.sh
@@ -82,29 +82,21 @@ Submodule name: 'a' for path 'b'
 Submodule name: 'submodule' for path 'submodule'
 EOF
 
-test_expect_success 'error in one submodule config lets continue' '
+test_expect_success 'error in history of one submodule config lets continue, stderr message contains blob ref' '
 	(cd super &&
 		cp .gitmodules .gitmodules.bak &&
 		echo "	value = \"" >>.gitmodules &&
 		git add .gitmodules &&
 		mv .gitmodules.bak .gitmodules &&
 		git commit -m "add error" &&
-		test-tool submodule-config \
-			HEAD b \
-			HEAD submodule \
-				>actual &&
-		test_cmp expect_error actual
-	)
-'
-
-test_expect_success 'error message contains blob reference' '
-	(cd super &&
 		sha1=$(git rev-parse HEAD) &&
 		test-tool submodule-config \
 			HEAD b \
 			HEAD submodule \
-				2>actual_err &&
-		test_i18ngrep "submodule-blob $sha1:.gitmodules" actual_err >/dev/null
+				>actual \
+				2>actual_stderr &&
+		test_cmp expect_error actual &&
+		test_i18ngrep "submodule-blob $sha1:.gitmodules" actual_stderr >/dev/null
 	)
 '
 
-- 
2.18.0
Previous: Antonio OspiteNext: Antonio Ospite
Message 9 of 14 in “Make submodules work if .gitmodules is not checked out”
  1. 0/9 Make submodules work if .gitmodules is not checked outAntonio Ospite, Aug 24, 2018
  2. 4/9 t7411: be nicer to future tests and really clean things upAntonio Ospite, Aug 24, 2018
  3. 1/9 submodule: add a print_config_from_gitmodules() helperAntonio Ospite, Aug 24, 2018
  4. Ævar Arnfjörð BjarmasonAug 24, 2018
  5. Antonio OspiteAug 24, 2018
  6. Antonio OspiteSep 4, 2018
  7. 9/9 submodule: support reading .gitmodules when it's not in the working treeAntonio Ospite, Aug 24, 2018
  8. 2/9 submodule: factor out a config_set_in_gitmodules_file_gently functionAntonio Ospite, Aug 24, 2018
  9. 3/9 t7411: merge tests 5 and 6Antonio Ospite, Aug 24, 2018
  10. 6/9 submodule: use the 'submodule--helper config' commandAntonio Ospite, Aug 24, 2018
  11. 8/9 submodule: add a helper to check if it is safe to write to .gitmodulesAntonio Ospite, Aug 24, 2018
  12. 7/9 t7506: clean up .gitmodules properly before setting up new scenarioAntonio Ospite, Aug 24, 2018
  13. 5/9 submodule--helper: add a new 'config' subcommandAntonio Ospite, Aug 24, 2018
  14. Ævar Arnfjörð BjarmasonAug 24, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.