ab/parse-options-cleanup
- From
Ævar Arnfjörð Bjarmason <avarab@gmail.com>
- Date
- Oct 13, 2021, 13:47 UTC
- Message-ID
- <87tuhlghnh.fsf@evledraar.gmail.com>
- In-Reply-To
- <xmqqv9239k15.fsf@gitster.g>
On Mon, Oct 11 2021, Junio C Hamano wrote:
Show 15 quoted lines
> * ab/parse-options-cleanup (2021-10-08) 10 commits
> - parse-options: change OPT_{SHORT,UNSET} to an enum
> - parse-options tests: test optname() output
> - parse-options.[ch]: make opt{bug,name}() "static"
> - commit-graph: stop using optname()
> - parse-options.c: move optname() earlier in the file
> - parse-options.h: make the "flags" in "struct option" an enum
> - parse-options.c: use exhaustive "case" arms for "enum parse_opt_result"
> - parse-options.[ch]: consistently use "enum parse_opt_result"
> - parse-options.[ch]: consistently use "enum parse_opt_flags"
> - parse-options.h: move PARSE_OPT_SHELL_EVAL between enums
>
> Random changes to parse-options implementation.
>
> Will merge to 'next'?Yes, I think the v3 re-roll I've got addressed your concerns about enum patterns, and I've got some meaningful (with a very negative diffstat) changes waiting on it.
https://lore.kernel.org/git/cover-v3-00.10-00000000000-20211008T190536Z-avarab@gmail.com/