git/list[1] front-page[2] threads[3] people[4] search[5] about
 

ab/unpack-trees-leakfix

From
Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date
Oct 13, 2021, 13:33 UTC
Message-ID
<877dehhwuq.fsf@evledraar.gmail.com>
In-Reply-To
<xmqqv9239k15.fsf@gitster.g>
On Mon, Oct 11 2021, Junio C Hamano wrote:
Show 7 quoted lines
> * ab/unpack-trees-leakfix (2021-10-07) 2 commits
>  - unpack-trees: don't leak memory in verify_clean_subdirectory()
>  - Merge branch 'ab/sanitize-leak-ci' into ab/unpack-trees-leakfix
>
>  Leakfix.
>
>  Will merge to 'next'?

I think it's ready, but I see you peeled of the 2nd and 3rd patch. I re-rolled a v3 which should address Elijah's outstanding comments there: with https://lore.kernel.org/git/cover-v3-0.3-00000000000-20211013T132223Z-avarab@gmail.com/

I can submit that after this one if you'd like, but having that missing clear_unpack_trees_porcelain() seems easy enough, and will make that API and its users leak-free.

Previous: Ævar Arnfjörð BjarmasonNext: Ævar Arnfjörð Bjarmason
Message 5 of 11 in “What's cooking in git.git (Oct 2021, #03; Mon, 11)”
  1. Junio C HamanoOct 12, 2021
  2. Submodules UX overhaul update (was: What's cooking in git.git (Oct 2021, #03; Mon, 11))Emily Shaffer, Oct 12, 2021
  3. Atharva RaykarOct 13, 2021
  4. ab/mark-leak-free-testsÆvar Arnfjörð Bjarmason, Oct 13, 2021
  5. ab/unpack-trees-leakfixÆvar Arnfjörð Bjarmason, Oct 13, 2021
  6. Ævar Arnfjörð BjarmasonOct 13, 2021
  7. ab/parse-options-cleanupÆvar Arnfjörð Bjarmason, Oct 13, 2021
  8. Junio C HamanoOct 13, 2021
  9. js/retire-preserve-merges, was Re: What's cooking in git.git (Oct 2021, #03; Mon, 11)Johannes Schindelin, Oct 14, 2021
  10. Ævar Arnfjörð BjarmasonOct 14, 2021
  11. Junio C HamanoOct 14, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.