git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] git-gui: sort entries in tclIndex

From
Pat Thoyts <patthoyts@users.sourceforge.net>
Date
May 1, 2015, 14:57 UTC
Message-ID
<87sibgpcpp.fsf@red.patthoyts.tk>
In-Reply-To
<553BC05F.1070702@web.de>
René Scharfe <l.s.r@web.de> writes:
Show 35 quoted lines
>Looping in Pat (git-gui maintainer).
>
>Am 15.04.2015 um 09:22 schrieb Olaf Hering:
>> Ping?
>>
>> On Tue, Feb 10, Olaf Hering wrote:
>>
>>> Ping?
>>>
>>> On Mon, Jan 26, Olaf Hering wrote:
>>>
>>>> ALL_LIBFILES uses wildcard, which provides the result in directory
>>>> order. This order depends on the underlying filesystem on the
>>>> buildhost. To get reproducible builds it is required to sort such list
>>>> before using them.
>>>>
>>>> Signed-off-by: Olaf Hering <olaf@aepfle.de>
>>>> ---
>>>>   git-gui/Makefile | 2 +-
>>>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/git-gui/Makefile b/git-gui/Makefile
>>>> index cde8b2e..7564a18 100644
>>>> --- a/git-gui/Makefile
>>>> +++ b/git-gui/Makefile
>>>> @@ -258,7 +258,7 @@ lib/tclIndex: $(ALL_LIBFILES) GIT-GUI-VARS
>>>>   	 rm -f $@ ; \
>>>>   	 echo '# Autogenerated by git-gui Makefile' >$@ && \
>>>>   	 echo >>$@ && \
>>>> -	 $(foreach p,$(PRELOAD_FILES) $(ALL_LIBFILES),echo '$(subst lib/,,$p)' >>$@ &&) \
>>>> +	 $(foreach p,$(PRELOAD_FILES) $(sort $(ALL_LIBFILES)),echo '$(subst lib/,,$p)' >>$@ &&) \
>>>>   	 echo >>$@ ; \
>>>>   	fi
>>>>
>
Applied. Thank you.
-- 
Pat Thoyts                            http://www.patthoyts.tk/
PGP fingerprint 2C 6E 98 07 2C 59 C8 97  10 CE 11 E6 04 E0 B9 DD
Previous: René ScharfeNext: Olaf Hering
Message 5 of 6 in “git-gui: sort entries in tclIndex”
  1. git-gui: sort entries in tclIndexOlaf Hering, Jan 26, 2015
  2. Olaf HeringFeb 10, 2015
  3. Olaf HeringApr 15, 2015
  4. René ScharfeApr 25, 2015
  5. Pat ThoytsMay 1, 2015
  6. Olaf HeringOct 5, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.