Re: [PATCH] git-gui: sort entries in tclIndex

From: Olaf Hering <olaf@aepfle.de>
Date: Feb 10, 2015, 15:18 UTC
Message-ID: <20150210151803.GB8965@aepfle.de>
In-Reply-To: <1422292043-12711-1-git-send-email-olaf@aepfle.de>

Ping?

On Mon, Jan 26, Olaf Hering wrote:

Show 23 quoted lines

> ALL_LIBFILES uses wildcard, which provides the result in directory
> order. This order depends on the underlying filesystem on the
> buildhost. To get reproducible builds it is required to sort such list
> before using them.
> 
> Signed-off-by: Olaf Hering <olaf@aepfle.de>
> ---
>  git-gui/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/git-gui/Makefile b/git-gui/Makefile
> index cde8b2e..7564a18 100644
> --- a/git-gui/Makefile
> +++ b/git-gui/Makefile
> @@ -258,7 +258,7 @@ lib/tclIndex: $(ALL_LIBFILES) GIT-GUI-VARS
>  	 rm -f $@ ; \
>  	 echo '# Autogenerated by git-gui Makefile' >$@ && \
>  	 echo >>$@ && \
> -	 $(foreach p,$(PRELOAD_FILES) $(ALL_LIBFILES),echo '$(subst lib/,,$p)' >>$@ &&) \
> +	 $(foreach p,$(PRELOAD_FILES) $(sort $(ALL_LIBFILES)),echo '$(subst lib/,,$p)' >>$@ &&) \
>  	 echo >>$@ ; \
>  	fi
>