Re: [PATCH v1 0/5] git log: configurable default format for merge diffs
- From
Sergey Organov <sorganov@gmail.com>
- Date
- Apr 11, 2021, 20:38 UTC
- Message-ID
- <87sg3w4kw6.fsf@osv.gnss.ru>
- In-Reply-To
- <xmqqo8ekhcfy.fsf@gitster.g>
Junio C Hamano <gitster@pobox.com> writes:
Show 10 quoted lines
> Sergey Organov <sorganov@gmail.com> writes: > >> 2. We have descriptive long name for every other option, and it'd be an >> exception if we'd have none for --diff-merges=m. In fact, it's >> --diff-merges=m that could have been removed, but it'd break resemblance >> with --cc and -c that both do have their --diff-merges=cc and >> --diff-merges=c counterparts. > > Hmph, a devil's advocate in me suspects that it may just be arguing > why user-configurable 'default' is a bad idea, though.
What feels bad about it? Is there something inherently wrong with an ability to configure a default and then request that default to be applied, using command-line option?
-- Sergey Organov