git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 3/9] diff-merges: introduce log.diffMerges config variable

From
Sergey Organov <sorganov@gmail.com>
Date
Apr 7, 2021, 22:56 UTC
Message-ID
<20210407225608.14611-4-sorganov@gmail.com>
In-Reply-To
<20210407225608.14611-1-sorganov@gmail.com>

New log.diffMerges configuration variable sets the format that --diff-merges=def will be using. The default is "separate".

Signed-off-by: Sergey Organov <sorganov@gmail.com>
---
 builtin/log.c |  2 ++
 diff-merges.c | 11 +++++++++++
 diff-merges.h |  2 ++
 3 files changed, 15 insertions(+)
diff --git a/builtin/log.c b/builtin/log.c
index 8acd285dafd8..6102893fccb9 100644
--- a/builtin/log.c
+++ b/builtin/log.c
@@ -481,6 +481,8 @@ static int git_log_config(const char *var, const char *value, void *cb)
 			decoration_style = 0; /* maybe warn? */
 		return 0;
 	}
+	if (!strcmp(var, "log.diffmerges"))
+		return diff_merges_config(value);
 	if (!strcmp(var, "log.showroot")) {
 		default_show_root = git_config_bool(var, value);
 		return 0;
diff --git a/diff-merges.c b/diff-merges.c
index 93ede09fb36f..ca4d94a9039d 100644
--- a/diff-merges.c
+++ b/diff-merges.c
@@ -90,6 +90,17 @@ static void set_diff_merges(struct rev_info *revs, const char *optarg)
  * Public functions. They are in the order they are called.
  */
 
+int diff_merges_config(const char *value)
+{
+	diff_merges_setup_func_t func = func_by_opt(value);
+
+	if (!func)
+		return -1;
+
+	set_to_default = func;
+	return 0;
+}
+
 int diff_merges_parse_opts(struct rev_info *revs, const char **argv)
 {
 	int argcount = 1;
diff --git a/diff-merges.h b/diff-merges.h
index 659467c99a4f..09d9a6c9a4fb 100644
--- a/diff-merges.h
+++ b/diff-merges.h
@@ -9,6 +9,8 @@
 
 struct rev_info;
 
+int diff_merges_config(const char *value);
+
 int diff_merges_parse_opts(struct rev_info *revs, const char **argv);
 
 void diff_merges_suppress(struct rev_info *revs);
-- 
2.25.1
Previous: Sergey OrganovNext: SZEDER Gábor
Message 8 of 47 in “git log: configurable default format for merge diffs”
  1. 0/9 git log: configurable default format for merge diffsSergey Organov, Apr 7, 2021
  2. 1/9 diff-merges: introduce --diff-merges=defSergey Organov, Apr 7, 2021
  3. Philip OakleyApr 8, 2021
  4. Sergey OrganovApr 8, 2021
  5. Junio C HamanoApr 8, 2021
  6. Sergey OrganovApr 8, 2021
  7. 2/9 diff-merges: refactor set_diff_merges()Sergey Organov, Apr 7, 2021
  8. 3/9 diff-merges: introduce log.diffMerges config variableSergey Organov, Apr 7, 2021
  9. SZEDER GáborApr 8, 2021
  10. SZEDER GáborApr 8, 2021
  11. Junio C HamanoApr 8, 2021
  12. Sergey OrganovApr 8, 2021
  13. 4/9 diff-merges: adapt -m to enable default diff formatSergey Organov, Apr 7, 2021
  14. 5/9 t4013: add test for --diff-merges=defSergey Organov, Apr 7, 2021
  15. 6/9 t4013: add tests for log.diffMerges configSergey Organov, Apr 7, 2021
  16. Ævar Arnfjörð BjarmasonApr 7, 2021
  17. Junio C HamanoApr 7, 2021
  18. Sergey OrganovApr 8, 2021
  19. 7/9 t9902: fix completion tests for log.d* to match log.diffMergesSergey Organov, Apr 7, 2021
  20. Ævar Arnfjörð BjarmasonApr 7, 2021
  21. Sergey OrganovApr 8, 2021
  22. Ævar Arnfjörð BjarmasonApr 8, 2021
  23. Sergey OrganovApr 8, 2021
  24. SZEDER GáborApr 8, 2021
  25. Sergey OrganovApr 8, 2021
  26. 8/9 doc/diff-options: document new --diff-merges featuresSergey Organov, Apr 7, 2021
  27. 9/9 doc/config: document log.diffMergesSergey Organov, Apr 7, 2021
  28. 0/5 git log: configurable default format for merge diffsSergey Organov, Apr 10, 2021
  29. 1/5 diff-merges: introduce --diff-merges=defaultSergey Organov, Apr 10, 2021
  30. 2/5 diff-merges: refactor set_diff_merges()Sergey Organov, Apr 10, 2021
  31. 3/5 diff-merges: adapt -m to enable default diff formatSergey Organov, Apr 10, 2021
  32. 4/5 diff-merges: introduce log.diffMerges config variableSergey Organov, Apr 10, 2021
  33. 5/5 doc/diff-options: document new --diff-merges featuresSergey Organov, Apr 10, 2021
  34. Junio C HamanoApr 11, 2021
  35. Sergey OrganovApr 11, 2021
  36. Junio C HamanoApr 11, 2021
  37. Sergey OrganovApr 11, 2021
  38. Sergey OrganovApr 11, 2021
  39. 0/5 git log: configurable default format for merge diffsSergey Organov, Apr 13, 2021
  40. 1/5 diff-merges: introduce --diff-merges=onSergey Organov, Apr 13, 2021
  41. Junio C HamanoApr 13, 2021
  42. 2/5 diff-merges: refactor set_diff_merges()Sergey Organov, Apr 13, 2021
  43. 3/5 diff-merges: adapt -m to enable default diff formatSergey Organov, Apr 13, 2021
  44. 4/5 diff-merges: introduce log.diffMerges config variableSergey Organov, Apr 13, 2021
  45. Junio C HamanoApr 15, 2021
  46. Sergey OrganovApr 16, 2021
  47. 5/5 doc/diff-options: document new --diff-merges featuresSergey Organov, Apr 13, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.