Re: [PATCH] git.el: Diff only file at point by default

From: Alexandre Julliard <julliard@winehq.org>
Date: Aug 30, 2008, 18:29 UTC
Message-ID: <87r686we4z.fsf@wine.dyndns.org>
In-Reply-To: <871w0bmn6w.fsf@lysator.liu.se>

David Kågedal <davidk@lysator.liu.se> writes:

Show 10 quoted lines

> Use prefix (C-u) to diff all marked files.
>
> Signed-off-by: David Kågedal <davidk@lysator.liu.se>
> ---
>  contrib/emacs/git.el |   62 +++++++++++++++++++++++++++++---------------------
>  1 files changed, 36 insertions(+), 26 deletions(-)
>
> Here is an updated patch that udpate the stage diff commands as
> well. It doesn't touch git-diff-file-merge-head since that already
> uses prefix arguments. Don't know if there is a solution to that.

I'd suggest to change git-diff-file-merge-head to act on the current file too. This means that the behavior is consistent across all diff functions, even if we lose the ability to do git-diff-file-merge-head on all marked files. Later on we may want to use a different mechanism than the prefix arg to toggle the marked file behavior for all diff functions (something like the pcl-cvs toggle-marks function).

Also make sure to check the callers of the diff functions you are changing; at least git-log-edit-diff got broken by your change, there may be others.

-- 
Alexandre Julliard
julliard@winehq.org