Re: [PATCH] git.el: Diff only file at point by default

From: Alexandre Julliard <julliard@winehq.org>
Date: Aug 25, 2008, 09:30 UTC
Message-ID: <87bpzh8msk.fsf@wine.dyndns.org>
In-Reply-To: <7v3akvw7gz.fsf@gitster.siamese.dyndns.org>

Junio C Hamano <gitster@pobox.com> writes:

Show 12 quoted lines

> David Kågedal <davidk@lysator.liu.se> writes:
>
>> Use prefix (C-u) to diff all marked files instead.
>>
>> Signed-off-by: David Kågedal <davidk@lysator.liu.se>
>> ---
>>  contrib/emacs/git.el |   13 +++++++++----
>>  1 files changed, 9 insertions(+), 4 deletions(-)
>>
>> For anyone who has used pcvs (or dsvn) this makes much more sense. The
>
> Looks sensible to me; Alexandre?

Looks OK to me, but I think you should apply the same treatment to all the other diff functions. Also the documentation string needs a bit more work.

-- 
Alexandre Julliard
julliard@winehq.org