git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Don't use $author_name undefined when $from contains no /\s</.

From
Paul Eggert <eggert@cs.ucla.edu>
Date
Oct 19, 2006, 23:48 UTC
Message-ID
<87pscnj29t.fsf@penguin.cs.ucla.edu>
In-Reply-To
<7vr6x4q9b6.fsf@assigned-by-dhcp.cox.net>
Junio C Hamano <junkio@cox.net> writes:
> If "trailing space" highlighting picks up the first column blank
> in "diff -u" output, that highlighting feature is *broken*.

If the buffer contains arbitrary text, some of which is diff -u output and some of which is not, then it it isn't possible in general for the highlighting mode to distinguish between the diff -u part and the other part. This sort of thing is fairly common among people who email patches and code around, or who generate files containing a combination of patches and other things.

If the change bothers you a lot, you might want to follow up to <http://www.opengroup.org/austin/mailarchives/ag-review/msg02139.html>, which proposes the change in question to the POSIX folks. This change is atop the earlier change I proposed to specify "diff -u" format in the first place; see <http://www.opengroup.org/austin/mailarchives/ag-review/msg02077.html>. You can follow up by writing to austin-group-l@opengroup.org and citing XCU ERN 103. You can find a copy of XCU ERN 103 at <http://www.opengroup.org/austin/aardvark/latest/xcubug2.txt>; look for "Number 103".

Since git uses diff -u format, it would make sense to git to work with the upcoming POSIX spec for diff -u, either by adjusting the spec or by adjusting git.

Previous: Junio C HamanoNext: Junio C Hamano
Message 7 of 10 in “Don't use $author_name undefined when $from contains no /\s</.”
  1. Don't use $author_name undefined when $from contains no /\s</.Jim Meyering, Oct 19, 2006
  2. Junio C HamanoOct 19, 2006
  3. Jim MeyeringOct 19, 2006
  4. Junio C HamanoOct 19, 2006
  5. Paul EggertOct 19, 2006
  6. Junio C HamanoOct 19, 2006
  7. Paul EggertOct 19, 2006
  8. Junio C HamanoOct 20, 2006
  9. Linus TorvaldsOct 20, 2006
  10. Jakub NarebskiOct 20, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.