git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Don't use $author_name undefined when $from contains no /\s</.

From
Junio C Hamano <junkio@cox.net>
Date
Oct 19, 2006, 21:34 UTC
Message-ID
<7vr6x4q9b6.fsf@assigned-by-dhcp.cox.net>
In-Reply-To
<87fydkj8q1.fsf@penguin.cs.ucla.edu>
Paul Eggert <eggert@CS.UCLA.EDU> writes:
Show 13 quoted lines
> Junio C Hamano <junkio@cox.net> writes:
>
>> I see no good reason, other than saving a single byte from the
>> output stream perhaps.
>
> That wasn't the motivation.  Rather, it was to support the
> style where people use editors that highlight trailing
> blanks, since trailing blanks can cause trouble in some
> contexts (e.g., they can change the semantics of C programs
> and Makefiles).  When examining unified diffs, any added or
> removed trailing blanks will be easy to spot with such an
> editor, but only if "diff -u" doesn't output any trailing
> blanks of its own.

If "trailing space" highlighting picks up the first column blank in "diff -u" output, that highlighting feature is *broken*.

"git diff --color" does the whitespace breakage highlighting, but it knows that the first column *is* not payload and does not highlight it.

> You can read more about this at the thread that inspired
> the diffutils change, rooted here:
>
> http://lists.gnu.org/archive/html/bug-gnu-utils/2006-09/msg00005.html

I've read it. It was not convincing and was not even an amusing read.

Previous: Paul EggertNext: Paul Eggert
Message 6 of 10 in “Don't use $author_name undefined when $from contains no /\s</.”
  1. Don't use $author_name undefined when $from contains no /\s</.Jim Meyering, Oct 19, 2006
  2. Junio C HamanoOct 19, 2006
  3. Jim MeyeringOct 19, 2006
  4. Junio C HamanoOct 19, 2006
  5. Paul EggertOct 19, 2006
  6. Junio C HamanoOct 19, 2006
  7. Paul EggertOct 19, 2006
  8. Junio C HamanoOct 20, 2006
  9. Linus TorvaldsOct 20, 2006
  10. Jakub NarebskiOct 20, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.