Re: [PATCH] gitk: Fix typo in proc blobdiffmaybeseehere

From: Thomas Rast <tr@thomasrast.ch>
Date: Dec 19, 2013, 23:16 UTC
Message-ID: <87ob4cctxx.fsf@linux-1gf2.Speedport_W723_V_Typ_A_1_00_098>
In-Reply-To: <52B29CB8.8090304@viscovery.net>

Johannes Sixt <j.sixt@viscovery.net> writes:

Show 18 quoted lines

> can't use non-numeric string as operand of "!"
>     while executing
> "if {!$ateof} {
> 	set nlines [expr {[winfo height $ctext]
> 			  / [font metrics textfont -linespace]}]
> 	if {[$ctext compare "$target_scrollpos + $nlines ..."
>     (procedure "maybe_scroll_ctext" line 5)
>
> Signed-off-by: Johannes Sixt <j6t@kdbg.org>
> ---
> Am 12/16/2013 14:56, schrieb Johannes Sixt:
>> To reproduce, start gitk in any repository, click a commit, then the
>> "back" button (left-pointing arrow button) or type Alt+Cursor-Left. The
>> error I get is this:
>> 
>> can't use non-numeric string as operand of "!"
>
> It turns out to be just a simple typo.

[...]

> -    maybe_scroll_ctext ateof
> +    maybe_scroll_ctext $ateof
>  }

Ew.  Sorry about that!

It's very polite of you to call it a typo, but I think it's safe to blame it on my lack of practice in Tcl :-)

-- 
Thomas Rast
tr@thomasrast.ch