[PATCH] gitk: Fix typo in proc blobdiffmaybeseehere
- From
Johannes Sixt <j.sixt@viscovery.net>
- Date
- Dec 19, 2013, 07:14 UTC
- Message-ID
- <52B29CB8.8090304@viscovery.net>
- In-Reply-To
- <52AF0688.3070104@viscovery.net>
From: Johannes Sixt <j6t@kdbg.org>
The recent 5de460a2 (Refactor per-line part of getblobdiffline and its support) introduced blobdiffmaybeseehere, and accidentally forgot the '$' to access the parameter as a TCL variable. This resulted in a failing "Back" button with the error
can't use non-numeric string as operand of "!"
while executing
"if {!$ateof} {
set nlines [expr {[winfo height $ctext]
/ [font metrics textfont -linespace]}]
if {[$ctext compare "$target_scrollpos + $nlines ..."
(procedure "maybe_scroll_ctext" line 5)Signed-off-by: Johannes Sixt <j6t@kdbg.org> --- Am 12/16/2013 14:56, schrieb Johannes Sixt:
Show 5 quoted lines
> To reproduce, start gitk in any repository, click a commit, then the > "back" button (left-pointing arrow button) or type Alt+Cursor-Left. The > error I get is this: > > can't use non-numeric string as operand of "!"
It turns out to be just a simple typo.
-- Hannes
gitk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/gitk b/gitk index 33c3a6c..1f14796 100755 --- a/gitk +++ b/gitk @@ -7922,7 +7922,7 @@ proc blobdiffmaybeseehere {ateof} { if {$diffseehere >= 0} { mark_ctext_line [lindex [split $diffseehere .] 0] } - maybe_scroll_ctext ateof + maybe_scroll_ctext $ateof } proc getblobdiffline {bdf ids} {
-- 1.8.5.1.1587.g3845a3d