git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] sha1_file: fix delta_stack memory leak in unpack_entry

From
Thomas Rast <tr@thomasrast.ch>
Date
Feb 22, 2014, 15:44 UTC
Message-ID
<87ob1zrw3e.fsf@thomasrast.ch>
In-Reply-To
<xmqqmwhk49sy.fsf@gitster.dls.corp.google.com>
Junio C Hamano <gitster@pobox.com> writes:
Show 18 quoted lines
> Jeff King <peff@peff.net> writes:
>
>> On Fri, Feb 21, 2014 at 06:47:47AM +0700, Nguyễn Thái Ngọc Duy wrote:
>>
>>> This delta_stack array can grow to any length depending on the actual
>>> delta chain, but we forget to free it. Normally it does not matter
>>> because we use small_delta_stack[] from stack and small_delta_stack
>>> can hold 64-delta chains, more than standard --depth=50 in pack-objects.
>>> 
>>> Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
>>> ---
>>>  Found when trying to see if making some objects loose at this phase
>>>  could help git-blame and how many objects will be loosened. Gotta go
>>>  soon, didn't really test it, but I bet it'll work.
>>
>> This looks correct to me.
>
> This comes from abe601bb, right?  The change looks correct to me, too.
Ow, sorry about that.  Thanks for the fix!
-- 
Thomas Rast
tr@thomasrast.ch
Previous: Jeff King
Message 5 of 5 in “sha1_file: fix delta_stack memory leak in unpack_entry”
  1. sha1_file: fix delta_stack memory leak in unpack_entryNguyễn Thái Ngọc Duy, Feb 20, 2014
  2. Jeff KingFeb 21, 2014
  3. Junio C HamanoFeb 21, 2014
  4. Jeff KingFeb 22, 2014
  5. Thomas RastFeb 22, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.