Re: [PATCH] sha1_file: fix delta_stack memory leak in unpack_entry

From: Jeff King <peff@peff.net>
Date: Feb 22, 2014, 08:12 UTC
Message-ID: <20140222081231.GC1576@sigill.intra.peff.net>
In-Reply-To: <xmqqmwhk49sy.fsf@gitster.dls.corp.google.com>

On Fri, Feb 21, 2014 at 10:09:33AM -0800, Junio C Hamano wrote:

Show 7 quoted lines

> >> This delta_stack array can grow to any length depending on the actual
> >> delta chain, but we forget to free it. Normally it does not matter
> >> because we use small_delta_stack[] from stack and small_delta_stack
> >> can hold 64-delta chains, more than standard --depth=50 in pack-objects.
> [...]
> 
> This comes from abe601bb, right?  The change looks correct to me, too.

Yes, it does.

-Peff