Re: [PATCH] New strbuf APIs: splice and attach.
Show 11 quoted lines
> On Sun, Sep 16, 2007 at 08:20:06PM +0000, Florian Weimer wrote:
>> * Pierre Habouzit:
>>
>> > +void strbuf_grow(struct strbuf *sb, size_t extra)
>> > +{
>> > if (sb->len + extra + 1 <= sb->len)
>> > die("you want to use way too much memory");
>>
>> By the way, this comparison is always false because sb->len is signed.
>
> News to me. Actually it's not, it's a size_t :)Ah, then this has changed somewhere. It used to be int. Good.