From: Florian Weimer <fw@deneb.enyo.de>
Date: Mon, 17 Sep 2007 05:43:30 GMT
Subject: Re: [PATCH] New strbuf APIs: splice and attach.
Message-ID: <87myvlzw1p.fsf@mid.deneb.enyo.de>
In-Reply-To: <20070916205136.GE26457@artemis.corp>

* Pierre Habouzit:

> On Sun, Sep 16, 2007 at 08:20:06PM +0000, Florian Weimer wrote:
>> * Pierre Habouzit:
>> 
>> > +void strbuf_grow(struct strbuf *sb, size_t extra)
>> > +{
>> >  	if (sb->len + extra + 1 <= sb->len)
>> >  		die("you want to use way too much memory");
>> 
>> By the way, this comparison is always false because sb->len is signed.
>
>   News to me. Actually it's not, it's a size_t :)

Ah, then this has changed somewhere.  It used to be int.  Good.