Re: [PATCH v3 19/21] t: add basic bitmap functionality tests

From: Thomas Rast <tr@thomasrast.ch>
Date: Dec 7, 2013, 16:43 UTC
Message-ID: <87mwkcipce.fsf@linux-1gf2.Speedport_W723_V_Typ_A_1_00_098>
In-Reply-To: <20131114124635.GS10757@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 7 quoted lines

> Now that we can read and write bitmaps, we can exercise them
> with some basic functionality tests. These tests aren't
> particularly useful for seeing the benefit, as the test
> repo is too small for it to make a difference. However, we
> can at least check that using bitmaps does not break anything.
>
> Signed-off-by: Jeff King <peff@peff.net>

Reviewed-by: Thomas Rast <tr@thomasrast.ch>

One nit:

> +test_expect_success JGIT 'jgit can read our bitmaps' '
> +	git clone . compat-us.git &&
> +	(
> +		cd compat-us.git &&

The name suggests a bare repo, but it is a full clone. Not that it matters.

-- 
Thomas Rast
tr@thomasrast.ch

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.