Re: [PATCH v3 13/21] pack-objects: implement bitmap writing

From

Thomas Rast <tr@thomasrast.ch>

Date

Dec 7, 2013, 16:32 UTC

Message-ID

<87d2l8k4es.fsf@linux-1gf2.Speedport_W723_V_Typ_A_1_00_098>

In-Reply-To

<20131114124544.GM10757@sigill.intra.peff.net>

Reviewed-by: Thomas Rast <tr@thomasrast.ch>

You could fix this:

> +pack.writebitmaps::
> +	When true, git will write a bitmap index when packing all
> +	objects to disk (e.g., as when `git repack -a` is run).  This

                               ^^

Doesn't sound right in my ears.  Remove the "as"?

> +	index can speed up the "counting objects" phase of subsequent
> +	packs created for clones and fetches, at the cost of some disk
> +	space and extra time spent on the initial repack.  Defaults to
> +	false.

-- 
Thomas Rast
tr@thomasrast.ch