Re: [PATCH 2/2] commit-template: distinguish status information unconditionally

From: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date: Jul 1, 2017, 11:44 UTC
Message-ID: <87mv8oe5zc.fsf@gmail.com>
In-Reply-To: <1498874344.2245.0.camel@gmail.com>

On Sat, Jul 01 2017, Kaartic Sivaraam jotted:

> On Fri, 2017-06-30 at 07:52 -0700, Junio C Hamano wrote:
>> Thanks, both looks good.Will queue.
> You're welcome :)

Just as someone reading this from the sidelines, very nice to have someone working this part of the UI, but it would be much easier to review if you included before/after examples of changes, e.g. (for this hypothetical change):

    
    Before we'd say:
    
        # Please enter the commit message for your changes. Lines starting
        # with '#' will be ignored, and an empty message aborts the commit.
        #
        # Date:      <date>
        #
        # On branch master
        # Your branch is up-to-date with 'origin/master'.
    
    Now:
    
        # Please enter the commit message for your changes. Lines starting
        # with '#' will be ignored, and an empty message aborts the commit.
        #
        # Date:      <date>
        #
        # On branch master
        # Your current branch is up-to-date with 'origin/master'.
    
    And as a word-diff:
    
        [...]
        # Your {+current+} branch is up-to-date with 'origin/master'.

Or something like that, much easier to read something like that than read the code and mentally glue together what it's going to change.