Re: [PATCH] Fix file mark handling and sort side-effects in git.el

From: Alexandre Julliard <julliard@winehq.org>
Date: Feb 15, 2009, 19:15 UTC
Message-ID: <87k57rh5qe.fsf@wine.dyndns.org>
In-Reply-To: <e38bce640902151035s18e374e6j25e3887728722700@mail.gmail.com>

Brent Goodrick <bgoodr@gmail.com> writes:

Show 7 quoted lines

> Ok, now that makes sense to me. Part of the problem here is that there
> is no statement in the user manual about git.el's intent to hide the
> index. Perhaps something to the effect of "If you are new to using
> Emacs but not new to git, then you need to know that bla bla ...".
> Otherwise, I think users may get tripped up by this as I was. Was
> there a manual in the works for git.el or did I just miss it in recent
> checkins?

There's no manual, and I'm not going to write one, I suck at writing documentation. If you would like to contribute one it would certainly be welcome.

Show 8 quoted lines

> However, the *git-status* buffer does properly reflect the two added
> files by their state being changed to "Added". Since you may have a
> ton of files that are being added, it probably doesn't make a whole
> lot of sense to dump a long message into the minibuffer with all of
> those names.  By the same token, it doesn't make sense to emit one
> message per file either. Instead, would you be willing to change that
> message to just state "Added n files" where "n" is the number of files
> added?

That's exactly what git-success-message already does. The only problem is that the list isn't always preserved properly (and that's only a cosmetic bug, the operations get carried out correctly).

-- 
Alexandre Julliard
julliard@winehq.org