Re: [PATCH] Fix file mark handling and sort side-effects in git.el

From: Alexandre Julliard <julliard@winehq.org>
Date: Feb 11, 2009, 10:56 UTC
Message-ID: <87hc31kzrb.fsf@wine.dyndns.org>
In-Reply-To: <18834.27724.991388.339214@hungover.brentg.com>

Brent Goodrick <bgoodr@gmail.com> writes:

> The `sort' Elisp function works destructively, causing anomalies where
> operations on multiple files would be performed on one file.  This
> checkin works around that by doing a deep copy with `append'.

This shouldn't be necessary, it's OK for git-status-update-files to destroy the list. If there are callers that want the list to be preserved they should save it themselves.

Show 5 quoted lines

> Also, git-add-file needed to pass 'modified to git-marked-files-state,
> as otherwise, files that are modified but not yet in the index would
> not show up in the git-marked-files-state return value, which would
> then cause a prompt for file to show up when the files are clearly
> marked in the status buffer.

Not sure what you mean here, it should not be possible for a file to be in modified state but not in the index. If you mean using git-add-file to do an update-index on an already tracked file, that's not what it's meant to do.

-- 
Alexandre Julliard
julliard@winehq.org